repeatFrequency must be accompanied by appropriate byDay/byMonth/byMonthDay values #362
Conversation
…yDay/byWeek/byMonthDay values
|
Noting that this came up in a recent conversation which noted a bug in the spec: openactive/modelling-opportunity-data#260, which impacts (3) above. Though it seems to already have been taken into account in the code of this PR (even if it's not obvious from the description of it)! |
|
|
||
|
|
||
| /* | ||
| Ensures that the value given in repeatFrequency is matched by an appropriate byDay, byWeek, or byMonth attribute. Possible values for repeatFrequency are in the first instance P[\d]D, P[\d]W, P[\d]M. In the first instance the repeatFrequency should be paired with a byDay attribute, in the second, byWeek, etc. Note that this test checks for the bare presence of appropriate attributes; there is no semantic checking |
There was a problem hiding this comment.
Is P[\d]Y also possible?
| } | ||
| // check frequency is valud | ||
| repeatFrequency = repeatFrequency.toLowerCase(); | ||
| const regexp = /^p\d(d|w|m)$/; |
There was a problem hiding this comment.
should this allow annual repeats?
|
The rule that monthly schedules must have |
|
Good catch @lukehesluke ! Feel free to request further changes! |
|
@thill-odi I've suggested a possible set of requirements here: openactive/modelling-opportunity-data#260 (comment). Let me know if that looks good or needs tweaking |
Ensures that:
repeatFrequencyis specifiedrepeatFrequencyis well-formed according to a limited subset of ISO 8601 duration valuesrepeatFrequencyvalue is accompanied by abyDay,byMonth, orbyMonthDayvalues.